fix: correctly place connaisseur-env-secret in deployment yaml #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbelitz
force-pushed
the
fix/helm-fix-env-secret
branch
from
e06a432
to
db0e41d
Compare
From chart version 2.4, a refactor was made that places connaisseur-env-secret under 'env' instead of under 'envFrom' in the deployment.This breaks cosign validations that require custom secrets like ECR
phbelitz
force-pushed
the
fix/helm-fix-env-secret
branch
from
db0e41d
to
7b48cd3
Compare
chrysogonus
approved these changes
Aug 23, 2024
This was referenced Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #1735 because of pipeline permission issues ... 😞
From chart version 2.4, a refactor was made that places connaisseur-env-secret under 'env' instead of under 'envFrom' in the deployment.This breaks cosign validations that require custom secrets like ECR
Fixes #1734
Checklist
developChart.yaml(if necessary)